search

softmaterialslab / nanoconfinement-md

This code allows users to simulate ions confined between material surfaces that are nanometers apart, and extract the associated ionic structure.
Apache License 2.0
5 stars 13 forks source link

Combined +/- density plots are added #53

Closed kadupitiya closed 6 years ago

kadupitiya commented 6 years ago

Combined +/- density plots are added.

kadupitiya commented 6 years ago

@jadhao @smarru : I checked this and it runs fine. Please have a look.

jadhao commented 6 years ago

@kadupitiya @smarru now approving this

smarru commented 6 years ago

it is working great. @jadhao wondering if we should make the combined plot the default? If so I can send a PR for it

kadupitiya commented 6 years ago

Ok. Thank you!

jadhao commented 6 years ago

@kadupitiya @smarru I think we should keep it secondary. If you now play with different steps or other parameters, and then hit ALL on rappture, the figure will be very crowded. Is that not the case?

jadhao commented 6 years ago

@kadupitiya please reply all to geoffrey's email saying that this feature is deployed. we are deciding whether to default it or keep it secondary option

kadupitiya commented 6 years ago

Ok. I will do that.

smarru commented 6 years ago

@jadhao you are right, ALL is making it very crowded. There is color coding, but still not easy to parse visually. + 1 to keep the combined one secondary.

kadupitiya commented 6 years ago

@jadhao Yeah. I also think that we can keep the combined plot as secondary option.