search

softonic / axios-retry

Axios plugin that intercepts failed requests and retries them whenever possible
Other
1.9k stars 167 forks source link

axios-retry incompatible with node 15.14.0 #180

Closed sksuryan closed 3 years ago

sksuryan commented 3 years ago

Hey, so yesterday with the latest updates to axios-retry it stopped working with Node 15.14.0. This seems to be related to the commit 03f9603 which adds engines property to package.json. I understand that 15.14 is not supported by Node anymore, but just wanted to ask if that was the only reason.

Thanks! Have a good day(or night timezones :P)!

mindhells commented 3 years ago

It's actually because of "peerDependency", which from version 3.2.1 on requires axios v0.21.2 or greater. Previous versions of axios have a vulnerability issue.

sksuryan commented 3 years ago

But if I'm not wrong, axios itself supports node v15.14.0 so why drop the compatibility in axios-retry?.

mindhells commented 3 years ago

Sorry I just read between lines before my first answer. The idea with engine limitations is to enforce using tested environments (https://github.com/softonic/axios-retry/actions/runs/1342316963). In the short term, the plan is to drop CommonJS as well (those are the minimum versions supporting ES modules). As mentioned before, we are also requiring a minimal axios version (with no vulnerabilities). Odd numbered versions of NodeJS are not meant for productive environments. You can always use an older version of axios-retry, or create a fork, for those environments.

mindhells commented 3 years ago

breaking requirements removed in 3.2.3