softonic / axios-retry

Axios plugin that intercepts failed requests and retries them whenever possible
Other
1.9k stars 167 forks source link

feat: export of type definitions, depending on whether it is ES Module or CommonJS #250

Closed yutak23 closed 1 year ago

yutak23 commented 1 year ago

This ought to fix https://github.com/softonic/axios-retry/issues/159.

The intent of this change is detailed in the issue. https://github.com/softonic/axios-retry/issues/159#issuecomment-1809406232

The following tests were performed to verify that axios-retry is available for all patterns.

environment

mindhells commented 1 year ago

Looks great, I'm publishing this as a minor

mindhells commented 1 year ago

Thanks a lot! published as 3.9.0

rchl commented 1 year ago

I haven't had time to look into those changes yet but it appears to break the import I had

import { IAxiosRetryConfig } from 'axios-retry'
mindhells commented 1 year ago

I haven't had time to look into those changes yet but it appears to break the import I had

import { IAxiosRetryConfig } from 'axios-retry'

@rchl can you please open an Issue with all the details? If you already know where the problem is and needs a fix in this lib, please don't hesitate to create a PR.