search

softonic / axios-retry

Axios plugin that intercepts failed requests and retries them whenever possible
Other
1.9k stars 167 forks source link

fix: enable name import #252

Closed yutak23 closed 1 year ago

yutak23 commented 1 year ago

This ought to fix https://github.com/softonic/axios-retry/issues/251.

One possible cause of the degradation is the lack of type definition testing.

Therefore, we will propose the addition of type definition testing in this PR. This test is similar to testing JavaScrip code, so I do not think this will significantly increase maintenance costs.

Rather, it would greatly improve the reliability of TypeScript type definitions.

※The scripts are daringly separated in test:tsd because tsd does not work due to CI's Node.js version. Local test results are below (Node.js v18.17.0). image

For Node.js v16.20.2 image

(I have not tested anything under Node 14 as I believe it has already reached EOL. cf. https://github.com/nodejs/Release#nodejs-release-working-group)

mindhells commented 1 year ago

Ok guys, thank you both for your dedication and feedback on this. I've just reverted the #250 in version 3.9.1 and I will work on the migration to TS soon