softonic / axios-retry

Axios plugin that intercepts failed requests and retries them whenever possible
Other
1.9k stars 167 forks source link

feat: add linearDelay for retryDelay option #285

Closed yutak23 closed 3 months ago

yutak23 commented 3 months ago

This ought to fix https://github.com/softonic/axios-retry/issues/276.

To allow the delayFactor to be changed, linearDelay is implemented to return the function required by the retryDelay option.

yutak23 commented 3 months ago

@mindhells, thank you for your review.

mindhells commented 3 months ago

thank you @yutak23 ! Only one more thing: it is required to sign the commits to merge your PR 🙏

yutak23 commented 3 months ago

thank you @yutak23 ! Only one more thing: it is required to sign the commits to merge your PR 🙏

@mindhells Added signatures. However, the force push caused other commits to be unsigned. Should I combine them into one commit and sign it?

mindhells commented 3 months ago

thank you @yutak23 ! Only one more thing: it is required to sign the commits to merge your PR 🙏

@mindhells Added signatures. However, the force push caused other commits to be unsigned. Should I combine them into one commit and sign it?

That'd be the best, so I don't have to bypass branch protections to merge 🙇

yutak23 commented 3 months ago

@mindhells , I apologize for the trouble i have caused you. I have pushed the commits together in a rebase and signed it.

mindhells commented 3 months ago

thanks a lot @yutak23 , this has been released as v4.5.0