search

softprops / action-gh-release

📦 :octocat: GitHub Action for creating GitHub Releases
MIT License
4.1k stars 450 forks source link

Do not raise misleading warning #389

Closed Drowze closed 7 months ago

Drowze commented 1 year ago

When the input input_files is not defined, the config.input_files will default to an empty array, which always evaluate to true - that was triggering a misleading warning suggesting that the user did input something but the input didn't point to any file.

As a fix, simply check if the array is empty as well :)

Drowze commented 11 months ago

@softprops can we merge this? would fix the following warning ("not include valid file") always being thrown whenever input_files is not defined. Screenshot 2023-11-01 at 14 29 11

rpdelaney commented 10 months ago

Duplicate of Related to #384 ? :)

softprops commented 7 months ago

@Drowze this makes a lot of sense to me!

softprops commented 7 months ago

this should be available in the new v2 tag