softprops / action-gh-release

📦 :octocat: GitHub Action for creating GitHub Releases
MIT License
3.91k stars 440 forks source link

Update node version to node20 #406

Closed timheuer closed 5 months ago

timheuer commented 6 months ago

Fixes #404 updating the action to use node20

s1204IT commented 6 months ago

@softprops Now that the node16 warning has started appearing, this should be addressed as soon as possible.

peabee commented 5 months ago

@softprops - would be great if this update could be actioned - thanks.

jamesbuddrige commented 5 months ago

+1 For upgrading this

lxiaya commented 5 months ago

update - thanks.

steven-prybylynskyi commented 5 months ago

@softprops merge it please

peabee commented 5 months ago

Now all we have to do is retagging the v1 tag!

Needs to be a new release...............??

timheuer commented 5 months ago

@softprops I'd recommend tagging as v2 (or major version bump). As an action owner myself, I updated other tags and had some consumers complain (rightfully) as because there are breaking changes between node16->node20 and thus having this in the flow caused other parts of their node scripts to fail, etc. So I re-released mine with major version bump for this reason. Just a thought ;-)

ivanlemeshev commented 5 months ago

Please create a new release. We need this action to work.

timheuer commented 5 months ago

As an alternate everyone you can modify your action to use a commit hash.

So you can use softprops/action-gh-release@ 4634c16e79c963813287e889244c50009e7f0981

this will use the merged node20 commit.

akinomyoga commented 5 months ago

@softprops Is there a plan to tag a new release? I'm wondering when I should update the GitHub actions in my projects. If the new tag will be released soon, I'd like to wait for it to avoid cluttering the history with a temporary change. If the new tag will not appear, I probably need to use the (temporary) solution suggested in https://github.com/softprops/action-gh-release/pull/406#issuecomment-1934635958.

barunprasad commented 5 months ago

We're currently awaiting compatibility of the latest tag with Node.js version 20. From my perspective, it would be advisable to consider a major version increment in light of this.

trackleft commented 5 months ago

@softprops hasn't done anything in github for a couple of weeks, hope he's OK

image
softprops commented 5 months ago

Sorry folks hope to get to this soon. I'm through a layoff event in my life and trying to prioritize getting certain things in order.

akinomyoga commented 5 months ago

Oh, I'm sorry to hear that. I can wait, so please take your time for your life. Needless to say, that's more important than GitHub Action. Don't worry, there are currently just warnings, and nothing is broken.

mikeage commented 5 months ago

I admit, I chuckled at the fact that of all the repos to be missing a release, it was this one ;-)

But seriously, I hope everything is ok and you're doing well. Work stress is never fun.

tychobrailleur commented 5 months ago

Sorry folks hope to get to this soon. I'm through a layoff event in my life and trying to prioritize getting certain things in order.

Virtual hug 🫂 Take care of yourself.

dirkhh commented 5 months ago

layoffs suck. life comes first. all the best

baruchiro commented 5 months ago

Hi man, working on an Open Source project for free is sometimes not rewarding. I can't promise we will find you a new job, but we are a small community here, if you need something from us, such as maintaining your OpenSource, sharing your LinkedIn post, connections, and so on, don't hesitate to ask 😍

TeamworkGIF

softprops commented 4 months ago

thanks for the support folks

sorry for the huge delay. This should now be fixed.

You should now use softprops/action-gh-release@v2.

I've validated this in a test run repo here

PS. THANK YOU everyone for your emotional support. I really need(ed) it.