Open networkhermit opened 5 months ago
Thanks for capturing this in one gh issue. It's possible this regressed in a version bump. The point of logging the error was to provide helpful debugging when something goes wrong. I agree it's not at all helpful at the moment printing undefined
.
I'm hoping to anyone willing to help with this one.
@softprops just ran into this too, can you try to dump the entire response since errors
seems undefined? Or what do you think is required to help?
It seems like I cannot run this from a branch? Like I need to run some command to regenerate dist
? If you can add details as I am also not familiar with TypeScript, then I can try to help.
@till ah yes, if you run npm install
to make sure you have dependencies installed then you can run npm build to generate a new packaged distribution file. This is ultimately what github actions uses as an entrypoint for the action
I just merged https://github.com/softprops/action-gh-release/pull/447 could someone on this issue thread try a test release using the current master branch of this action? once we starting seeing data it should start shaking out the underlying issue
That was supposed to be for testing 😆
no worries. the more info we can gather the sooner we can get the underlying issue addressed
I figured out my problem: PAT was missing some permissions. In the end used the workflow token again and configured it appropriately.
Currently when the action fails it displays undefined as part of the error message, which is not very helpful for debugging.
I believe the specific line is in https://github.com/softprops/action-gh-release/blob/9b795e578288d5ff64564dfa7dd4cda7b04bb648/src/github.ts#L316
It seems that more helpful error message can be displayed (taken from my scratch fork to troubleshooting a coredns release issue):
Related issue showing undefined: #217 #400 #411 #429
I'm not very familiar with typescript and the tooling used, so I hope some existing contributor or volunteer could help improve it.
Even more helpful error message other than plain undefined is appropriated too.