Upgrade serde, remove syntex dependency to allow unknown JSON in input

softprops / afterparty

rust github webhook server

MIT License

55 stars 13 forks source link

Upgrade serde, remove syntex dependency to allow unknown JSON in input #16

Closed ms705 closed 7 years ago

ms705 commented 7 years ago

This PR allows the JSON parsing of webhook payloads to succeed despite the input containing unknown fields (e.g., the undocumented organization dict of the Push event coming from a repo owned by a GitHub organization).

serde 0.7+ by default ignores unknown fields, rather than panicking when it encounters them, so upgrading it actually fixes the underlying problem that contributed to #13 and #15.

Fixes #11.

softprops commented 7 years ago

For some reason I already thought I did this. Thank you so much for grabbing it. I'll publish a new version soon

softprops commented 7 years ago

published let me know if you find anything