search

softprops / atty

are you or are you not a tty?
MIT License
277 stars 50 forks source link

Consider MIT/Apache-2.0 license? #30

Open alexcrichton opened 6 years ago

alexcrichton commented 6 years ago

I was personally a little confused recently when I discovered the isatty crate as we'd previously been using this crate for things like rustc and Cargo. Upon opening an issue seeking clarification it seems like the main difference is licensing. Would you be open to relicensing with Rust's same dual license? We may then be able to hopefully consolidate crates!

softprops commented 6 years ago

I'm all for consolidating.

Before I do this would you be able to walk me though concrete benefits and drawbacks of doing this? I made a pit stop at a few crates I use often that were also asked to do this and one ended up sticking with MIT https://github.com/hyperium/hyper/issues/1277 and one ended up going dual but dual MIT or UNLICENSE https://github.com/BurntSushi/chan/issues/4.

I'm not opposed to changing the licensing but I'd like to understand the implications before I do. I typically default to MIT because its the only license I've every understood!

alexcrichton commented 6 years ago

Ah to be honest I'm not actually sure! We've historically been pretty liberal with anything MIT/etc licensed (whether or not it's dual with Apache-2.0). I personally use MIT/Apache-2.0 to be the same as the Rust project itself, but I don't have a ton of opinions about licenses myself.

In that sense this was mostly opened because that's what it sounded like should happen, although I'm not actually sure if it really needs to happen.