search

softprops / atty

are you or are you not a tty?
MIT License
274 stars 51 forks source link

Support no_std on windows #49

Open Plecra opened 3 years ago

Plecra commented 3 years ago

https://github.com/softprops/atty/blob/7b5df17888997d57c2c1c8f91da1db5691f49953/src/lib.rs#L131

By replacing this vector with an array, we can remove the std dependency. The allocation is only 524 bytes long, and it wouldn't be unreasonable to allocate it on the stack (Rust's default stack size is 2MiB, giving us plenty of room).

We'd also need to remove the utf16 conversion that allocates to a string here:

https://github.com/softprops/atty/blob/7b5df17888997d57c2c1c8f91da1db5691f49953/src/lib.rs#L146

One solution would simply be to write s.contains(&[b'-' as u16, 'p' as _, 't' as _, 'y' as _]), but there's also https://docs.rs/utf16_lit which makes this more readable

BurntSushi commented 3 years ago

@Plecra Could you say what the use case is for no_std support on Windows? Where would it allow the use of this crate that is otherwise impossible today? Making the substring check even more obscure, for example, seems non-ideal.