diffset current replies on GITHUB_REF and an assume but configurable base, currently "master".
This works well enough for typically diffsets in pushes to pr branches but not at all for merges to master. The reason bying that the GITHUB_REF always represents the ref that triggered to pull request which is in the case of a merge to master, a push to master so comparing master to master will always yield an empty set.
how ever we can leverage another bit of information. GITHUB_SHA refers to the direct commit that commit pushed which in the case of a merge is the sha of the merge. we can't exactly use the same comparison api for compare/sha...master because they would also yield an empty sets.
instead we can detect the case of a ref being the same as a base and use an an alternative strategy for fetching a list of files involved in the GITHUB_SHA
diffset current replies on GITHUB_REF and an assume but configurable base, currently "master".
This works well enough for typically diffsets in pushes to pr branches but not at all for merges to master. The reason bying that the GITHUB_REF always represents the ref that triggered to pull request which is in the case of a merge to master, a push to master so comparing master to master will always yield an empty set.
how ever we can leverage another bit of information. GITHUB_SHA refers to the direct commit that commit pushed which in the case of a merge is the sha of the merge. we can't exactly use the same comparison api for
compare/sha...masterbecause they would also yield an empty sets.instead we can detect the case of a ref being the same as a base and use an an alternative strategy for fetching a list of files involved in the GITHUB_SHA