softprops / hubcaps

a rust interface for github
http://docs.rs/hubcaps
MIT License
279 stars 68 forks source link

repositories: support listing commits #226

Closed grahamc closed 5 years ago

grahamc commented 5 years ago

What did you implement:

https://developer.github.com/v3/repos/commits/

  1. list commits
  2. get a single commit

Has a couple todos, called out with github comments. What do you think from here?

How did you verify your change:

cargo run --example repo_commits
cargo test

I also cargo fmt'd my added changes, and didn't add unrelated reformats.

What (if anything) would need to be called out in the CHANGELOG for the next release:

nothing, I think :)

softprops commented 5 years ago

Looks great!