softprops / hubcaps

a rust interface for github
http://docs.rs/hubcaps
MIT License
279 stars 68 forks source link

CheckRun.id is too small for new runs (i32) #289

Closed swarkentin closed 2 years ago

swarkentin commented 3 years ago

It looks like run IDs have exceeded the i32 max.

https://github.com/softprops/hubcaps/blob/a9e6616ecc7b8eef0ea0eaf6055d9610c8961500/src/checks.rs#L186

This is a recent example (run id = 2280865524):

https://github.com/ForAllSecure/api-fuzzer-swagger-petstore-demo/runs/2280865524

This fix will break consumers of CheckRun, but bumping to a u64 or replacing the id with a String is necessary to work with any new runs.