search

softprops / hyperlocal

🔌 ✨rustlang hyper bindings for local unix domain sockets
MIT License
227 stars 46 forks source link

Switch to `std:future::Future` and `async/await`. #25

Closed reitermarkus closed 4 years ago

reitermarkus commented 5 years ago

The client part has basically remained the same, the server part however has been completely replaced with an extension trait on Hyper's Server.

Currently depends on Rust nightly, Tokio master and Hyper master.

softprops commented 5 years ago

This looks super dope @reitermarkus. I just need a bit of time to catch up on this works and I'll merge

softprops commented 4 years ago

Is there an eta on when this could be releaseable on stable rust?

reitermarkus commented 4 years ago

This is stabilized in Rust 1.39.

softprops commented 4 years ago

Looks like hyper had a release https://seanmonstar.com/post/187493499882/hyper-alpha-supports-asyncawait

ebkalderon commented 4 years ago

@reitermarkus Async/await is stable and out in the wild! I was about to open a pull request against this repo, but I noticed this one already existed. Is it still being actively worked on? I would really like to see this crate brought to feature parity with upstream hyper.

danieleades commented 4 years ago

i hadn't seen this branch before opening https://github.com/softprops/hyperlocal/pull/29

what's the status of this?

reitermarkus commented 4 years ago

what's the status of this?

Depends on what @ebkalderon wants to do here. Either release an alpha with this or wait for hyper 0.13 to be stable.

ebkalderon commented 4 years ago

@reitermarkus I didn't realize I was blocking a decision, haha. I believe an alpha release wouldn't hurt for the sake of letting intrepid users iterate faster, as long as transitioning to stable hyper is easy to achieve and anticipated breakage is relatively minimal. It is labeled an alpha release, after all.

With that said, I believe that final judgment should be reserved by the PR author and project owner(s) in this case, and I would equally respect the decision to wait, especially if the next release is right around the corner.

reitermarkus commented 4 years ago

@ebkalderon, I actually meant to tag @softprops here, sorry. 😉

reitermarkus commented 4 years ago

I do agree though that an alpha wouldn't hurt to get the ball rolling and that any future changes will be relatively minimal at this stage compared to all of the changes in this PR.

softprops commented 4 years ago

It looks the the ecosystem is starting to fall into place. Tokio recently released an official non alpha 0.2.x release line and it seems the futures crate released an official non-alpha 0.3.x release line

This pull seems to be the most complete changeset so I'll merge this. It's a holiday weekend for me so I may not get to it this weekend but I think it would be a good idea to bring the cargo deps in this project up to the latest stable versions now available in the ecosystem.