softprops / hyperlocal

🔌 ✨rustlang hyper bindings for local unix domain sockets
MIT License
227 stars 46 forks source link

port hyperlocal client to latest hyper #29

Closed danieleades closed 4 years ago

danieleades commented 4 years ago

This was required to support porting shiplift to futures 0.3 (https://github.com/softprops/shiplift/pull/191).

I've disabled the server implementation for now, and have ported only the client.

softprops commented 4 years ago

@danieleades I just merged https://github.com/softprops/hyperlocal/pull/25 let me know if that unblocks what you were blocked on for this pull

danieleades commented 4 years ago

tokio has just released a stable release using futures::Stream, instead of futures-preview::Stream. I would expect Hyper to bump it's dependency any day now. Once that happens, this pull request should be updated, or if it is merged, a new pull request should be opened for that update.

only then will i be unblocked downstream (otherwise we have a mixture of futures-preview::Stream and futures::Stream in the dependencies, and they don't play nicely together).

danieleades commented 4 years ago

i'm happy this is ready to merge. it's a major change, and a big refactor of the client and uri modules.

danieleades commented 4 years ago

For visibility, hyper has just merged the move to futures, rather than futures-preview. Once this is released, hyperlocal should bump the hyper dependency and move to stable tokio

danieleades commented 4 years ago

hyper has just released. will update this pull request in the next couple of days.

danieleades commented 4 years ago

this is now updated to latest hyper.

danieleades commented 4 years ago

closes #23

danieleades commented 4 years ago

closes #22

danieleades commented 4 years ago

ping @softprops

softprops commented 4 years ago

Sorry for the many delays on this. @danieleades I'll try to commit to going though this but the end of the weekend.

softprops commented 4 years ago

This looks great! I'm shoot for a release this weekend