softprops / serverless-localhost

MIT License
9 stars 6 forks source link

commit dist per https://github.com/softprops/serverless-localhost/issues/12 #15

Open dsilva opened 4 years ago

dsilva commented 4 years ago

What did you implement:

Commit the dist directory to git as mentioned in https://stackoverflow.com/questions/46619788/npm-install-from-a-git-repo-leaves-a-pretty-blank-package

Closes: #12

What did you need this functionality for

After installing this package with npm, the node_modules/serverless-localhost/ directory contains just package.json, README.md, LICENSE, and CHANGELOG.md. The dist directory is missing.

Consequently running serverless localhost fails with

Serverless plugin "serverless-localhost" not found. Make sure it's installed and listed in the "plugins" section of your serverless config file.

How did you verify your change:

The dist directory was present after installing from a local fork.

What (if anything) would need to be called out in the CHANGELOG for the next release:

y2kappa commented 4 years ago

I can confirm this works, I used his fork as a source for the package installation and the /dist folder appears in node_modules.