softprops / serverless-rust

⚡ 🦀 a serverless framework plugin for rustlang applications
https://www.npmjs.com/package/serverless-rust
MIT License
545 stars 82 forks source link

CI Pipeline Compatibility #124

Open TravisCalder opened 1 year ago

TravisCalder commented 1 year ago

What did you implement:

Closes: #123

How did you verify your change:

Change was verified locally using npm link locally. The following scenarios were verified:

seanpianka commented 1 year ago

Thanks for these changes! I think at this point in this project lifecycle, you might be be better off starting your own fork of this project since this version of it has been abandoned.

I have been looking at gathering the changes from the different PR's available, and pre-existing forks, and merging them into one that we can continue development on.

TravisCalder commented 1 year ago

I noticed when I forked that some tests weren't passing.

Added a commit with lint passing (my mistake), updates to the test for my code, and fixes to the pre-existing failures.

TravisCalder commented 12 months ago

Thanks for these changes! I think at this point in this project lifecycle, you might be be better off starting your own fork of this project since this version of it has been abandoned.

I have been looking at gathering the changes from the different PR's available, and pre-existing forks, and merging them into one that we can continue development on.

We did fork internally and it's working like a charm, but I figured it only made sense to at least offer it back.

Low expectations on getting it merged in, but at the very least the diff is there for others who want similar behaviour.

nrodriguez-chub commented 10 months ago

@TravisCalder you have just implemented what I was planning to do! This part to skip the build, is critical for us :D :D :
https://github.com/TravisCalder/serverless-rust/blob/master/index.js#L303 Did you publish a public release of this or are you planning to do so? Thanks!

TravisCalder commented 9 months ago

I didn't see this reply, sorry about that. We're keeping an internal build of it since we use GitLab but you're welcome to use the code from this Pull Request. We're using it now for 4 different Serverless deployments with 1-3 lambdas per deployment and it's working like a charm.

On Wed, Nov 15, 2023 at 5:02 AM nrodriguez-chub @.***> wrote:

@TravisCalder https://github.com/TravisCalder you have just implemented what I was planning to do! This part to skip the build, is critical for us :D :D : https://github.com/TravisCalder/serverless-rust/blob/master/index.js#L303 Did you publish a public release of this or are you planning to do so? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/softprops/serverless-rust/pull/124#issuecomment-1812290347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG6A4ZWJOF36KUT4IRA7N3YESOM5AVCNFSM6AAAAAA5L26A2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGI4TAMZUG4 . You are receiving this because you were mentioned.Message ID: @.***>