This pull request upgrades all dependencies to their latest version and fix incompatible code. Specifically, this updates tokio from 0.2 to 1.0, which makes shiplift usable in newer projects.
What did you implement:
Changed version strings in Cargo.toml.
Implemented a special case for unix:/// URLs, since "unix:///var/run/docker.sock".parse::<hyper::Uri>() will now return an error saying the authority can't be empty.
Created unit test for this special case.
For some reason there is an empty /lib.rs. This pull request also removed it.
How did you verify your change:
cargo test --no-default-features pass
cargo test pass
Tried cargo run --example info with DOCKER_HOST set to unix:///..., http://... and tcp://... URLs.
Verified that creating containers, starting and attaching to them still works, since I'm using this on my own project.
What (if anything) would need to be called out in the CHANGELOG for the next release:
No changes to the interface is made, however this would probably require a minor version bump, since updating tokio will force dependent of this project to also update their tokio as well.
softprops
commented
3 years ago
This pull request upgrades all dependencies to their latest version and fix incompatible code. Specifically, this updates tokio from 0.2 to 1.0, which makes shiplift usable in newer projects.
What did you implement:
unix:///URLs, since"unix:///var/run/docker.sock".parse::<hyper::Uri>()will now return an error saying the authority can't be empty./lib.rs. This pull request also removed it.How did you verify your change:
cargo test --no-default-featurespasscargo testpasscargo run --example infowithDOCKER_HOSTset tounix:///...,http://...andtcp://...URLs.What (if anything) would need to be called out in the CHANGELOG for the next release:
No changes to the interface is made, however this would probably require a minor version bump, since updating tokio will force dependent of this project to also update their tokio as well.