softprops / shiplift

🐳 🦀 rust interface for maneuvering docker containers
MIT License
624 stars 119 forks source link

Add StopSignal and StopTimeout to ContainerOptionsBuilder #248

Closed elihunter173 closed 3 years ago

elihunter173 commented 3 years ago

What did you implement:

I added options to set the StopSignal and StopTimeout options in /container/create.

Since StopSignal can be either a string or a number, I added methods for both. I thought about using nix::sys::signal::Signal but it seemed unnecessary to bring in the entire library for a single enum.

How did you verify your change:

I tested this manually on my codie-discord project which uses shiplift.

What (if anything) would need to be called out in the CHANGELOG for the next release:

The changelog was updated in this PR.