softprops / shiplift

🐳 🦀 rust interface for maneuvering docker containers
MIT License
617 stars 119 forks source link

Add supported API version to README #53

Open blankenshipz opened 7 years ago

blankenshipz commented 7 years ago

I don't think that v1.26 of the remote API is currently supported, I think the README should be updated with information related to the minimum and max supported versions.

blankenshipz commented 7 years ago

I added a Dockerfile and docker-compose.yml locally to test against a specific version of the API:

# Dockerfile
FROM liuchong/rustup:stable

RUN mkdir -p /usr/src/app
WORKDIR /usr/src/app

COPY . /usr/src/app

CMD ["cargo", "run"]
# docker-compose.yml
version: '2'

services:
  app: &default
    build:
      context: .
      dockerfile: Dockerfile
    links:
      - dockerapi
    volumes:
      - .:/usr/src/app
      - registry:/root/.cargo/registry # Allows for caching dependencies 

  dockerapi:
    image: docker:1.12.6-dind
    privileged: true

volumes:
  registry:
    driver: local

This allows for running an application that usesshiplift against a known version of the docker remote api using the dind image.

matthiasbeyer commented 3 years ago

I guess this is still relevant, isn't it? Can we maybe somehow integrate such an setup in our CI? What do you think?