84/87/DartCollision

[koktavy]

Bit of trial and error in getting this feature working. Tried to commit often, so my earlier commits here may be redundant. Changes:

• New dartboard from prefabs of individual ring sections, to avoid hitting sections behind.
• Dart respawning was updated, Floor and DartHolder objects are no longer used.
• Colliders have been updated on DartVariant prefab, along with an added Physic Material.
• Bit of a juggle between scripts to get this working while still assigning points; When darts collide with the board, they are frozen in place by ThrowRealDart.cs, and once the collision script in PointsAssigner.cs runs on the dartboard ring, that changes the tag on the dart so that it is not picked up by another section in the event of collision near ring edges.

(Edit: clarifying emphasis on my commits for this PR)

[charleswdickstein]

It seems like the pull request is stating you made all these features by yourself, which I'm not a fan of. it would be more accurate to say that this pull request refactors code from the features mentioned. Also, I get these errors:

NullReferenceException: Object reference not set to an instance of an object GoogleARCoreInternal.ARCoreAndroidLifecycleManager.ResetSession () (at Assets/ARPlugin/GoogleARCore/SDK/Scripts/Managers/ARCoreAndroidLifecycleManager.cs:143) GoogleARCore.ARCoreSession.OnDestroy () (at Assets/ARPlugin/GoogleARCore/SDK/Scripts/ARCoreSession.cs:82)

Instant Preview requires your Unity Android SDK path to be set. Please set it under 'Preferences > External Tools > Android'. You may need to install the Android SDK first. UnityEngine.Debug:LogError(Object) GoogleARCoreInternal.d__11:MoveNext() (at Assets/ARPlugin/GoogleARCore/SDK/InstantPreview/Scripts/InstantPreviewManager.cs:174) UnityEngine.MonoBehaviour:StartCoroutine(IEnumerator) GoogleARCoreInternal.ARCoreAndroidLifecycleManager:CreateSession(ARCoreSession) (at Assets/ARPlugin/GoogleARCore/SDK/Scripts/Managers/ARCoreAndroidLifecycleManager.cs:118) GoogleARCore.ARCoreSession:Awake() (at Assets/ARPlugin/GoogleARCore/SDK/Scripts/ARCoreSession.cs:73)

[koktavy]

I didn't mean for it to sound that way, I was only trying to be thorough in describing the edits I made. This project is without a doubt a team effort, and going through the project history and commit diffs will show that.

That first error seems to be a documented bug in the ARCore Unity SDK, I have added the fix from this issue of the SDK repo: https://github.com/google-ar/arcore-unity-sdk/issues/505.

The second error looks to be specific to the Instant Preview feature of the same SDK, which I use to stream my phone's camera feed to the Unity editor. I've unchecked the "Instant Preview enabled" box in the ARCore Project Settings menu for now, but we may all need to have the ARCore SDK later on once we start working with Cloud Anchors, we'll see. Let me know if that fixes it! Thank you.

[asunwoo98]

The background is a white screen when I compile it on iPhone? I can only see buttons

[asunwoo98]

maybe requires detect platform to be implemented beforehand

[asunwoo98]

Looks like was just a debugging problem.