search

software-challenge / backend

Server, Client und Spiel-Plugins der Software-Challenge Germany
https://www.software-challenge.de
11 stars 10 forks source link

Refactor/convert round based game instance #340

Closed anarchuser closed 3 years ago

anarchuser commented 3 years ago

Rebased off https://github.com/CAU-Kiel-Tech-Inf/backend/pull/339 (which thus should be merged first).

This is an important conversion, in my eyes. The RoundBasedGameInstance is buried within java code quite deeply, making interactions with kotlin code annoying (e.g., overwriting of java getters) and potentially introducing errors.

anarchuser commented 3 years ago

As far as I can tell, all tests run successful now. However, with the current state the GUI fails to recognise Game Over

xeruf commented 3 years ago

Now I have some local changes to the RoundBasedGameInstance as well. To avoid confusion I think we should merge this before that though...

anarchuser commented 3 years ago

However, with the current state the GUI fails to recognise Game Over

This seems to be working properly now

xeruf commented 3 years ago

Just realized that we track round and turn in both GameState and Game, yikes... Another issue for another day...

SKoschnicke commented 3 years ago

Just realized that we track round and turn in both GameState and Game, yikes... Another issue for another day...

Created new issue for that #354

xeruf commented 3 years ago

Thanks @SKoschnicke :)