feat(controller): provide roomId on game creation and game over

xeruf commented 3 years ago

not even sure whether this makes sense, but wanted to put it on record just in case here's what I think we should do:

ensure the CancelRequest works (https://github.com/CAU-Kiel-Tech-Inf/backend/pull/228)
return a new object called GameHandle with the possibility to cancel the game, attach listeners (so the startNewGame method doesn't have to handle all that by itself) and stop listening to a game altogether
make it clear that there is one LobbyManager per Game (didn't notice that until recently)
fix our weird event propagation by making it more consistent with the backend listeners - which should also use events rather than individual listener interfaces with lots of methods

SKoschnicke commented 3 years ago

This general plan is also good, but should be split into multiple PRs, right?

xeruf commented 3 years ago

is better

in what regard? It doesn't really change any behavior so far ;)

SKoschnicke commented 3 years ago

in what regard? It doesn't really change any behavior so far ;)

Using a Future is better than using a callback.

xeruf commented 3 years ago

well, currently I have implemented an unused Future in addition to the callback ;) but ofc that is supposed to change

xeruf commented 3 years ago

This isn't the way to go, different approach is already underway

software-challenge / gui