ana-oprescu
commented
7 years ago | Exercise 1 | Comments | Exercise 2 | Comments | Exercise 3 | Comments | Exercise 4 | Comments | Exercise 5 | Comments | Exercise 6 | Comments | Exercise 7 | Comments | Exercise 8 | Comments | Total |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 10 | Excellent | 6 | Tests are well implemented. However, you are not considering memory as a metric. A deeper analysis of your findings, where you mention means, stdev, grow rate, etc. is missing | 9 | Why not starting in 4? Since you know that 2 and 3 are not composites | 7 | Very good, can be improved by continuing the test even after finding the first false positive, and printing all the found false positives | 5 | Analysis is kind of short. In your tests/analysis you are not taking into account that a Carmichael number N fools the Fermat test if you check aˆ(N−1) for some a that is coprime with N. An analysis/test on that direction is needed | 7 | ->issues | 5 | ->issues | 10 | ->issues | 8 |