software-engineering-amsterdam / ST2017_WG_4

0 stars 0 forks source link

Feedback Lab 1 #3

Open ana-oprescu opened 7 years ago

ana-oprescu commented 7 years ago
Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Bonus Exercise 9 Comments Bonus Exercise 10 Comments Total
6 Not quickCheck test implemented, no timing, no discussion about why the solution was selected 6 no timing, no quickcheck test provided, no discussion, answer not entirely correct, you are not testing mathematical fact 7 no timing, no quickcheck test provided, no discussion 6 no timing, no discussion neither testing provided 6 no timing, no discussion neither testing provided 10 Perfect 5 missing required tests for isCardType 9 -> issues 7 ok 5 nice implementation for Euler 10; unconvincing Euler 49; lots of compilation problems, due to implicit imports 7.475
visknut commented 7 years ago

I have two comments on recurring points of feedback for most of the exercises.