search

software-engineering-amsterdam / ST2017_WG_9

0 stars 0 forks source link

Feedback Lab 2 #3

Open hdmeyer opened 6 years ago

hdmeyer commented 6 years ago
Group # Exercise 1 Comments Exercise 2 Comments Exercise 3 Comments Exercise 4 Comments Exercise 5 Comments Exercise 6 Comments Exercise 7 Comments Exercise 8 Comments Total
9 9 Good solution and good analysis. No timing 10 Good solution. Good testset 4 you have not provided a descendent strength list. What means u1? 4 isPermutation is wrong 6 Where are the tests? 8 Nice general solution. The role of parameter n is unclear. Function if alphabet is hardcoded in rotateChar then n must be too. 10 Well done 8 Good solutions to easy problems. 8.085714286
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
schneider-simon commented 6 years ago

Hello @hdmeyer

thank you for your valuable feedback. We can see the flaws in almost all of our exercises.

Nonetheless, there is one feedback we could not quite understand. Would you please explain to us why there are tests missing in Exercise5? It includes a testReport in the comments and a long list of predicates and tests. (l 127-159)

We test if the derangement function produces lists that: have the same length as the output (predicate1), contain the same elements (predicate 2), are a permutation (predicate1+ predicate2) and that they do not share elements at the same position (predicate3).

We can not think of anything else we could test since these 3 predicates exactly mirror the specification.

hdmeyer commented 6 years ago

Hello Simon,

@BertLisser could you please answer this question?

Cheers,

BertLisser commented 6 years ago

Hello Simon

Sorry, I overlooked the top lines. The tests with properties which has one argument are okay. But the tests with two arguments are not. The event that random an dearangement will be generated is very small like in: testSameElements :: [Int] -> [Int] -> Bool

so the precondition will not be satisfied (mostly). In these cases you test nothing.

To see this use verboseCheck.

The rating will be raised to 7.

Kind regards Bert

----- Original Message ----- From: "Simon Schneider" notifications@github.com To: "software-engineering-amsterdam/ST2017_WG_9" ST2017_WG_9@noreply.github.com Cc: "Subscribed" subscribed@noreply.github.com Sent: Tuesday, September 26, 2017 12:56:36 PM Subject: Re: [software-engineering-amsterdam/ST2017_WG_9] Feedback Lab 2 (#3)

Hello @hdmeyer

thank you for your valuable feedback. We can see the flaws in almost all of our exercises.

Nonetheless, there is one feedback we could not quite understand. Would you please explain to us why there are tests missing in Exercise5? It includes a testReport in the comments and a long list of predicates and tests. (l 127-159)

We test if the derangement function produces lists that: have the same length as the output (predicate1), contain the same elements (predicate 2), are a permutation (predicate1+ predicate2) and that they do not share elements at the same position (predicate3).

We can not think of anything else we could test since these 3 predicates exactly mirror the specification.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/software-engineering-amsterdam/ST2017_WG_9/issues/3#issuecomment-332162275