search

software-engineering-amsterdam / ST2018_WG_9

2 stars 0 forks source link

Lab 5 #4

Open BertLisser opened 6 years ago

BertLisser commented 6 years ago

Exercise 1. Complements for the good documentation. Exercise 2. Very good an well documented but refactoring can be more complete. In many more places is it possible to replace Constraints by[Position]. For example

type Node = (Sudoku,[Position])
prune :: (Row,Column,Value)
      -> [Position] -> [Position]
constraints :: Sudoku -> [Position]

Exercise 4 Where is the test that the solution is unique?

Exercise 5 There must be something wrong. I see nearly the same code as in exercise 4. But running Main works well.

p-kostic commented 6 years ago

This is certainly true and we completely glanced over it! What will be the impact on the grading for notions like these?