software-gardening / almanack

An open-source handbook of applied guidance and tools for sustainable software development and maintenance.
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Update workflow permissions to fix deploy error #31

Closed d33bs closed 1 month ago

d33bs commented 1 month ago

Description

Fixes an error with completing the deploy book jobs which I believe deal with permissions. It's a bit strange as this error doesn't always surface in other areas I've used the action. Just the same, the docs recommend updating to this option (or others) (under "warning").

What is the nature of your change?

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

netlify[bot] commented 1 month ago

Deploy Preview for test-almanac ready!

Name Link
Latest commit 63a2e41f4ea140babf387b3d6733600f89e8671e
Latest deploy log https://app.netlify.com/sites/test-almanac/deploys/663d39a1f1f6b40008a6cea3
Deploy Preview https://deploy-preview-31--test-almanac.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

d33bs commented 1 month ago

Thanks @vincerubinetti - the settings change is a better one! After making that change and re-running the job, it succeeded. I'm going to close without merge here as a result.