search

software-jessies-org / jessies

Terminator, Evergreen, lwm and friends
GNU General Public License v2.0
84 stars 19 forks source link

Incompatible with OpenJDK 10 #24

Closed jonathan-teh closed 6 years ago

jonathan-teh commented 6 years ago

Starting evergreen, or checkintool, results in:

$ evergreen
Evergreen requires Java 6 or newer.

Your /usr/bin/java claims to be 10.0.1.

Please upgrade.

Package 27.168.7080
Revision 7080 (7080)
Built 2018-03-25T09:21:20-07:00

Ubuntu 18.04's default-jre is OpenJDK 10 (https://wiki.ubuntu.com/BionicBeaver/ReleaseNotes#OpenJDK):

$ java -version
openjdk version "10.0.1" 2018-04-17
OpenJDK Runtime Environment (build 10.0.1+10-Ubuntu-3ubuntu1)
OpenJDK 64-Bit Server VM (build 10.0.1+10-Ubuntu-3ubuntu1, mixed mode)

Worked around with:

--- invoke-java.rb.orig 2018-05-01 22:25:55.036353357 +0100
+++ invoke-java.rb      2018-05-01 22:26:33.571361408 +0100
@@ -201,7 +201,7 @@
   end

   def is_java_new_enough(java_version)
-    return (java_version.match(/^(1\.)?[6-9]/) != nil)
+    return (java_version.match(/^(1\.)?[6-9]/) != nil) || (java_version.match(/^(1[0-9]\.)/) != nil)
   end

   def check_java_version()
martindorey commented 6 years ago

Ooh, I hadn't noticed that it was raised as a github issue rather than just an email, or I'd have cited the issue in my supposed fix. Thanks for the report.