search

software-mansion-labs / expo-maps

81 stars 3 forks source link

Reverse `GoogleMaps` pod update (downgrade to 6.0.0) #76

Closed szdziedzic closed 2 years ago

szdziedzic commented 2 years ago

Why

After updates in #72 it seems like camera position is malfunctioning on Google Maps for iOS. I wasn't able to fix this bug using newer version 6.2.0 so far, but downgrade to previous version 6.0.0 helps as a temporary fix for this issue, so we have stable version of the demo app on main branch. We should create a separate PR in which we update this pod to newer version and resolve this issue.

Before (6.2.0):

https://user-images.githubusercontent.com/55145344/170604598-3f139ba5-ce56-42c5-a188-46aedae2394d.MOV

After (6.0.0)

https://user-images.githubusercontent.com/55145344/170604766-8411d45e-e3a5-42b9-8486-a91169956548.MOV

How

Downgrade GoogleMaps pod to version 6.0.0.

Test Plan

iOS

szdziedzic commented 2 years ago

It's actually our fault, because from what I can see we didn't have GoogleMaps dependency version specified in the right place and that's the reason why it got updated by your PR. It should be fixed by this PR. Thanks!