search

software-mansion-labs / react-native-turbo-demo

React Native Turbo - an open source library that can bring your turbo-enabled web application into the React Native world.
MIT License
101 stars 11 forks source link

Ensure that `RNVisitableViewController` is always defined #183

Closed pklatka closed 5 months ago

pklatka commented 5 months ago

Summary

This PR refactors the way of using the RNVisitableViewController in RNVisitableView - now every time the controller variable is accessed, it is caught by a proxy which checks if the controller is nil and takes appropriate action as needed.

Test plan

yarn clean && yarn && yarn dev:ios

pfeiffer commented 5 months ago

Under what circumstances could the controller be nil and the need for this new proxy be effectuated?

pklatka commented 5 months ago

Closing for now, need to investigate the issue more.