search

software-mansion / asdf-scarb

Scarb plugin for the asdf version manager
https://docs.swmansion.com/scarb
MIT License
7 stars 1 forks source link

Stop printing redirect URL #11

Closed mkaput closed 1 year ago

mkaput commented 1 year ago

Problem

It happens that we break output from some commands by printing the redirect URL 😱 I think it'd be the easiest if we drop it entirely, but we would very appreciate it if it could be conditionally printed during normal installation.

Steps

$ asdf latest --all
elixir  main-otp-26 missing
erlang  26.0.2  missing
nodejs  20.5.1  missing
python  stackless-3.7.5 missing
ruby    truffleruby+graalvm-23.0.0  missing
redirect url: https://github.com/software-mansion/scarb/releases/tag/v0.6.2
scarb   0.6.2   installed
terraform   1.5.5   missing

Possible Solution(s)

No response

Notes

Please leave a comment that you are willing to contribute a PR fixing this issue before starting doing so, in order to avoid having two people working on this independently 😄

Does this issue reproduce in the latest version of asdf-scarb?

gaetbout commented 1 year ago

Can I try this one?

mkaput commented 1 year ago

Sure, go on, but perhaps wait for https://github.com/software-mansion/asdf-scarb/pull/10 to be merged :)

gaetbout commented 1 year ago

I subscribed to #10, I'll wait then :)

gaetbout commented 1 year ago

can you elaborate on what is a "normal installation"?

mkaput commented 1 year ago

can you elaborate on what is a "normal installation"?

OK, so I think it'd be still awesome if we have a possibility to tell users what version is going to be installed when they type one of the following:

asdf install scarb latest
asdf install scarb latest:nightly
asdf local scarb latest
asdf global scarb latest

etc. These commands are what I meant by normal installation; sorry for mental shortcut.

This was the original purpose of printing that URL. It was just a poor man solution.