software-mansion / protostar

Protostar is a toolchain for developing and testing Starknet contracts
https://docs.swmansion.com/protostar/
MIT License
247 stars 48 forks source link

Add missing (test) assertions #61

Closed Arcticae closed 2 years ago

Arcticae commented 2 years ago

Compared to Foundry

kasperski95 commented 2 years ago

I think there's no point of adding assertions.

Foundry (ds-test)* starkware.cairo.common.math
assertTrue assert_not_zero
assertEq assert_not_equal
assertEqDecimal -
assertGt -
assertGe -
assertLt assert_lt
- assert_lt_felt
assertLe assert_le
- assert_le_felt
- assert_nn
- assert_nn_le
- assert_250_bit
- assert_in_range
- static_assert

*Each assert has a corresponding variant that accepts an error message or/and different data type.

kasperski95 commented 2 years ago

Make naming and importing consistent.