search

software-mansion / radon-ide

VSCode extension that turns your editor into a fully fledged IDE for React Native and Expo.
https://ide.swmansion.com
Other
867 stars 29 forks source link

Modify line reader to always consume stderr and mark stderr in callback #560

Closed kmagiera closed 1 week ago

kmagiera commented 1 week ago

This PR modifies the behavior of lineReader which would previously only tried on reading from stderr when requested.

Since typically stderr is used to pass on important information and given almost all uses in out codebase would set stderr as true, this method now connects to stderr by default.

For the use-cases where we want to be able to tell whether line comes from stderr or stdout (like with the sim-server stdout that is used as communication and control channel), the line callback gets an additional argument that indicates whether line comes from stderr.

Test plan

Run expo-router, try clean rebuild on Android and iOS

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:09am