Add Open Deep Link modal

software-mansion / radon-ide

VSCode extension that turns your editor into a fully fledged IDE for React Native and Expo.

https://ide.swmansion.com

Other

985 stars 33 forks source link

Add Open Deep Link modal #640

Closed km1chno closed 1 week ago

km1chno commented 3 weeks ago

Resolves #631

Changes

Adds shared component <SearchSelect/>, which is used in Open Deep Link modal.
The component allows to select option from scrollable list and provides search bar, which performs some simple version of fuzzy search, it doesn't support matching with misspellings, but allows for holes (basically for search phrase abc this is matching to regex *a*b*c*).
Adds "Open Deep Link" modal that allows to input a deep link to open in app and browse history of recently opened deep links, which is cached in workspace state (only last 50 entries are cached).

Demos (dark and light mode)

https://github.com/user-attachments/assets/2ac2018f-66c5-4c65-8a84-326b26e4106e

https://github.com/user-attachments/assets/0e65ccd7-1fbe-457f-9ad0-1228079a277a

How Has This Been Tested:

Tested in light and dark mode, on Iphone 15 Pro sim and Pixel 9 emulator, on projects expo-router and react-native-75.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
radon-ide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 0:35am

km1chno commented 2 weeks ago

I pushed some changes, the modal now has static height and there is only one input field which acts kind of like a search bar in browser (I tried to match the behavior of https://github.com/junegunn/fzf).

kmagiera commented 2 weeks ago

From the UX perspective it makes little sense to have the magnifier glass icon there. It is an input field that also narrows down the history list.

I'd perhaps just leave it without any icon and instead add placeholder "Enter deeplink or search history"

I'd also experiment with adding some label for the list of previous entries such that it is clear what we show there. For example "History" or "Previously used URLs"

km1chno commented 2 weeks ago

@kmagiera what do you think about something like this?

kmagiera commented 2 weeks ago

Looks good!

km1chno commented 1 week ago

I will get back to this once #675 is merged so we can use app level cache for storing recently used deep links

kmagiera commented 1 week ago

There's no reason to wait, this is accepted for a few days already. #675 only changes the storage for build result metadata, we're still storing other settings and data in workspace-specific storage. It doesn't make sense to put URLs storage in that cache leaving other settings in workspace cache as it is conceptually closer to device settings than it is to native builds.

km1chno commented 1 week ago

Ok then I'm merging this one. When the app level cache is created and we feel a need to move app level settings there from workspace state, then we can move cached deep links too.