software-mansion / radon-ide

VSCode extension that turns your editor into a fully fledged IDE for React Native and Expo.
https://ide.swmansion.com
Other
985 stars 33 forks source link

Use new save command to fix issue with empty replays #647

Closed kmagiera closed 3 weeks ago

kmagiera commented 3 weeks ago

This PR brings on the changes from simulator-server that aim to address the issue with empty / erronous replays.

This issue would arise in when user enables the replays for the device and then w/o any interaction with the screen would snap a replay. With the previous version, this would result in an error, as sim-server wouldn't register any frames since replays were enabled. The second issue was similar but had to do with the fact that after snapping the replay we'd need to stop and start replays again, resulting in the same behavior that'd arise immediately after starting. For this purpose save command have been introduced that apart from fixing the issue would let the video buffer retain frames when saving. This way the follow-up replays can also contain frames from previous ones if they are not that far apart.

This PR: 1) Bumps simulator-server version to one that includes aforementioned fixes 2) Updates the code to use save command. We are also removing IDs that we'd previously used for individual recording session as now we only have one session that stops only when the user disables replays in the device setting.

How Has This Been Tested:

  1. Run one project on iOS and Android with replays disabled
  2. Enable replays and snap replay w/o doing anything on the screen -> see that a very short replay gets recorded
  3. Do something with the screen and record another replay
  4. Close replay, do some more stuff on screen and record another one -> see that the last one also includes recording of the screen from before the previous replay was recorded
vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 9:14am