This PR brings on the changes from simulator-server that aim to address the issue with empty / erronous replays.
This issue would arise in when user enables the replays for the device and then w/o any interaction with the screen would snap a replay. With the previous version, this would result in an error, as sim-server wouldn't register any frames since replays were enabled. The second issue was similar but had to do with the fact that after snapping the replay we'd need to stop and start replays again, resulting in the same behavior that'd arise immediately after starting. For this purpose save command have been introduced that apart from fixing the issue would let the video buffer retain frames when saving. This way the follow-up replays can also contain frames from previous ones if they are not that far apart.
This PR:
1) Bumps simulator-server version to one that includes aforementioned fixes
2) Updates the code to use save command. We are also removing IDs that we'd previously used for individual recording session as now we only have one session that stops only when the user disables replays in the device setting.
How Has This Been Tested:
Run one project on iOS and Android with replays disabled
Enable replays and snap replay w/o doing anything on the screen -> see that a very short replay gets recorded
Do something with the screen and record another replay
Close replay, do some more stuff on screen and record another one -> see that the last one also includes recording of the screen from before the previous replay was recorded
This PR brings on the changes from simulator-server that aim to address the issue with empty / erronous replays.
This issue would arise in when user enables the replays for the device and then w/o any interaction with the screen would snap a replay. With the previous version, this would result in an error, as sim-server wouldn't register any frames since replays were enabled. The second issue was similar but had to do with the fact that after snapping the replay we'd need to stop and start replays again, resulting in the same behavior that'd arise immediately after starting. For this purpose
save
command have been introduced that apart from fixing the issue would let the video buffer retain frames when saving. This way the follow-up replays can also contain frames from previous ones if they are not that far apart.This PR: 1) Bumps simulator-server version to one that includes aforementioned fixes 2) Updates the code to use
save
command. We are also removing IDs that we'd previously used for individual recording session as now we only have one session that stops only when the user disables replays in the device setting.How Has This Been Tested: