software-mansion / radon-ide

VSCode extension that turns your editor into a fully fledged IDE for React Native and Expo.
https://ide.swmansion.com
Other
998 stars 35 forks source link

Record user and session data properly for telemetry #748

Closed kmagiera closed 5 days ago

kmagiera commented 5 days ago

This PR fixes the issue with telemetry module that wasn't collecting user-id and session-id properly resulting in all the telemetry events being squashed under a single user and session.

The main fix for user-id reporting has already landed in the new version of telemetry package https://github.com/microsoft/vscode-extension-telemetry/pull/210 We also submitted a PR that has been merged to address the session ID issue: https://github.com/microsoft/vscode-extension-telemetry/pull/215

Because there's been no release since that update, we're installing a fork of telemetry module with our changes included from https://github.com/software-mansion-labs/vscode-extension-telemetry Since the package requires a build-step, we've uploaded bundled JS files into the fork repository and install the dependency using github link.

The new version of telementy module now requires a so-called "connection string" instead of just the instrumentation key as the first argument. Because of that we're also updating the public key value.

How Has This Been Tested:

  1. Change panelOpen event to panelOpen-test20
  2. Open extension
  3. Check in Application Insights that the new event arrived and it has distinct user id and session set.
vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 3:52pm