search

software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
6.12k stars 981 forks source link

Chat heads Example not working in Android! #180

Closed victorkvarghese closed 6 years ago

victorkvarghese commented 6 years ago

Hi,

Great Library :) Lots of features to use .. thanks a lot.

I tried running the chat heads example from the repo. https://github.com/kmagiera/react-native-gesture-handler/blob/master/Example/chatHeads/index.js

Its working great in iOs and but I was not able to get it working on android. Its not draggable in android.

Any help would be appreciated!

React native : 0.55.4 react-native-gesture-handler@1.0.0

osdnk commented 6 years ago

@victorkvarghese Thank you for using this library and getting interested into this example. However, this screen is not working right now and calls for changes in React Native core. We believe it will be done as soon as possible. https://github.com/kmagiera/react-native-gesture-handler/blob/3e2ff380ebadaf13b40504af9115ed1e7bf1215a/Example/App.js#L52 Mind that this example is not listed in the main screen. We're conscious that it does not work properly right now. What is more, even though it seems to be working fine on iOS, it does not use native drivers so it's only kind of proof of concept. If you wish to see the problem, uncomment this and see how it works when JS thread is busy 😢 I close the issue as it's not matter of our library right now.

victorileaf commented 6 years ago

@kmagiera Any progress on chat heads feature??

filiptdz commented 6 years ago

@osdnk could you please elaborate on what needs to be changed for this? I'd love to know why this doesn't work

osdnk commented 6 years ago

@filiptdz I suppose there's some problems with Animated library. I tried to fork RN in order to make it workable, but I didn't manage neither @kmagiera.

However there's a hope! Please let you use https://github.com/kmagiera/react-native-reanimated/tree/master/Example/chatHeads

filiptdz commented 6 years ago

@osdnk Actually I'm writing an article about animations, and wanted to make sure I wasn't missing something obvious. Thanks for the help! This made me realize what was going on.

In case someone comes across this thread and wants to know why, on Animated, animations with useNativeDriver can't follow other animated values. Therefore, you need reanimated for this to work using the native driver.

osdnk commented 6 years ago

hope to see it! 😍