Closed m-bert closed 2 months ago
Looks like there still are some things left to iron out
All captured on Android 13, Chrome 118.0.5993.111
@j-piasecki I agree that there are some problems that should be fixed. However, I've checked the one with swipeable
on main
and it seems that it is already there, even without this PR. Could you please check if that's true?
However, I've checked the one with swipeable on main and it seems that it is already there, even without this PR. Could you please check if that's true?
Works fine for me on the current main
(8d3d5e0b7)
@m-bert What's blocking this pull request from getting a review?
iOS doesn't seem to work at all yet - all handlers are running simultaneously with scrolling the page and navigation gestures
Hi @GuestInCorle!
Problems that @j-piasecki described seem to affect both platforms, Android and iOS.
I'm not sure about the navigation part and I have yet to check that. However, most of the issues seem to originate from default minDistance
in PanGestureHandler
(which right now is set to 15px, see this line). By manipulating this value I was able to achieve what I think is the solution that we are looking for.
This PR was superseded by #2788, followed by #2794.
Description
During development of web version we initially decided to set
touchAction: none
to all gesture handlers' views in order to avoid scrolling while gestures like pan are active. Now it turns out that because of this decision, components likeFlatList
orScrollView
may become useless when combined with some handlers (or, like in the issue mentioned below -Swipeable
components).This PR aims to fix that problem by replacing
touchAction: none
withe.preventDefault()
.Fixes #2617
Test plan
Tested on:
ScrollView
andLoremIpsum
)Modified code from issue