search

software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
5.85k stars 954 forks source link

Remove circular dependencies on web #2783

Closed m-bert closed 2 months ago

m-bert commented 2 months ago

Description

While working on problems with scroll we discovered that Gesture Handler has many circular dependencies. This PR removes them from web implementation (the only one that's left is related to hammer). It also adds madge - tool to find circular dependencies in our project.

Test plan

Run yarn madge --extensions js,ts,tsx --circular src | grep web from root.

m-bert commented 2 months ago

Turns out that there was one more dependency introduced in #2788. Right now we should be good to go.