Adjust Android build.gradle to to run project with Gradle 8

software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.

https://docs.swmansion.com/react-native-gesture-handler/

MIT License

5.83k stars 952 forks source link

Adjust Android build.gradle to to run project with Gradle 8 #2785

Closed norman-kapschefsky closed 1 month ago

norman-kapschefsky commented 2 months ago

Description

To build the android project with gradle 8+, the added configs are required.

Test plan

Tested in Android project with ...

gradle 8.2
gradle 7.6

j-piasecki commented 1 month ago

We already set namespace and buildConfig depending on AGP version: https://github.com/software-mansion/react-native-gesture-handler/blob/d55d8de21bce537aaef2c8f30a4a50a0ce4cc152/android/build.gradle#L102-L110

If that's not enough in your case, can you share more details about your setup?

norman-kapschefsky commented 1 month ago

We already set namespace and buildConfig depending on AGP version:

https://github.com/software-mansion/react-native-gesture-handler/blob/d55d8de21bce537aaef2c8f30a4a50a0ce4cc152/android/build.gradle#L102-L110

If that's not enough in your case, can you share more details about your setup?

Thx for your respond @j-piasecki Ah my bad. Due to the fact, that we use an older version of "react-native-gesture-handler", I thought its missing. Sorry.

Good that you have it already 👍. Will close the PR.