This is a follow-up PR to #2787 that is meant to fix scrolling of swipeable elements. It overrides shouldHandlerBeCancelledBy method so that activeNativeViewGestureHandler that is not a button, will cancel other handler.
Keep in mind that on web, if scroll has already started we cannot cancel it by calling preventDefault, hence it makes sense to cancel other handlers in that case (but we may want to limit it just to Pan).
Fixes #2617
Test plan
Tested on
Swipeable example in our example app
Transformations example with added text to achieve scrolling
Modified code from #2617
Description
This is a follow-up PR to #2787 that is meant to fix scrolling of swipeable elements. It overrides
shouldHandlerBeCancelledBy
method so that activeNativeViewGestureHandler
that is not a button, will cancel other handler.Keep in mind that on web, if scroll has already started we cannot cancel it by calling
preventDefault
, hence it makes sense to cancel other handlers in that case (but we may want to limit it just toPan
).Fixes #2617
Test plan
Tested on
Modified code from #2617