Closed latekvo closed 8 months ago
I am still polishing up some details, but if you have any questions or suggestions, feel free to ask.
I actually want to ask for your opinion, current cornerFillAlignmentList
initialisation prevents corners from being calculated if enableCornerActivation
is false
, but since that will probably never happen, i feel like including that condition only makes the code less readable.
So instead, i could move this condition a few lines lower to isAligned
like this:
const alignmentList = Object.values(Directions).map((direction) =>
getAlignment(direction, this.minimalAlignmentCosine)
);
const cornerFillAlignmentList = Object.values(CornerDirections).map((direction) =>
getAlignment(direction, this.minimalCornerAlignmentCosine)
);
const isAligned = alignmentList.some(Boolean) || (cornerFillAlignmentList.some(Boolean) && this.enableCornerActivation);
I will apply all relevant changes to the kotlin side in the next commit.
Description
This PR implements a requested feature to activate fling on corners of two adjacent activated directions.
Test plan
yarn
example/
and runyarn
yarn web
for Web oryarn start
for IOS and Android