Support for Kotlin 2.0 - Githubissues

software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.

https://docs.swmansion.com/react-native-gesture-handler/

MIT License

6.13k stars 982 forks source link

Support for Kotlin 2.0 #2960

Closed pvdmde closed 4 months ago

pvdmde commented 4 months ago

Description

Looks like there's an issue when using Kotlin 2.0 in the app.

Steps to reproduce

Update kotlin version to 2.0

Snack or a link to a repository

nope

Gesture Handler version

not up to date, but code looks similar now

React Native version

0.73.0

Platforms

Android

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

github-actions[bot] commented 4 months ago

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

pvdmde commented 4 months ago

Current line:

https://github.com/software-mansion/react-native-gesture-handler/blob/cbf270ca5c00f749790ff2d3191d190250191425/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandlerOrchestrator.kt#L618

j-piasecki commented 4 months ago

Could you verify that https://github.com/software-mansion/react-native-gesture-handler/pull/2964 solves the problem in your case?

pvdmde commented 4 months ago

Confirmed. Thanks! Hope to see a release with this one :)

pvdmde commented 4 months ago

I'd like to ask for a patch release with this one, as it fixes a blocker to update.

pvdmde commented 4 months ago

@j-piasecki can you trigger a release to unblock upgrading projects to kotlin 2.0?

j-piasecki commented 3 months ago

We'll most likely release it early next week