Closed latekvo closed 4 months ago
@m-bert I think you mentioned adding a CI workflow dedicated to making sure we don't introduce another cycle by accident, is that happening?
@j-piasecki Yes, I did mention adding CI workflow 😅 In order for it to make sense we have to get rid of all circular dependencies. At the beginning we didn't care that much about the one connected with Hammer
, so it was postponed. Now that I see that we did remove all circular dependencies, I think adding CI workflow would be good idea.
Also, we could add it to pre-commit hook, let me know what do you think.
@latekvo could you add this workflow?
@m-bert alright, should I add it to this PR, or do you think it deserves one of it's own?
I think it would be nice to add it in this PR 😅
This PR removes circular dependencies found via:
yarn madge --extensions js,ts,tsx --circular src