software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
6.13k stars 982 forks source link

Resolve circular dependencies on JS side #2970

Closed latekvo closed 4 months ago

latekvo commented 4 months ago

This PR removes circular dependencies found via:

yarn madge --extensions js,ts,tsx --circular src

j-piasecki commented 4 months ago

@m-bert I think you mentioned adding a CI workflow dedicated to making sure we don't introduce another cycle by accident, is that happening?

m-bert commented 4 months ago

@j-piasecki Yes, I did mention adding CI workflow 😅 In order for it to make sense we have to get rid of all circular dependencies. At the beginning we didn't care that much about the one connected with Hammer, so it was postponed. Now that I see that we did remove all circular dependencies, I think adding CI workflow would be good idea.

Also, we could add it to pre-commit hook, let me know what do you think.

@latekvo could you add this workflow?

latekvo commented 4 months ago

@m-bert alright, should I add it to this PR, or do you think it deserves one of it's own?

m-bert commented 4 months ago

I think it would be nice to add it in this PR 😅

latekvo commented 4 months ago

New madge workflow

image