software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
6.13k stars 982 forks source link

Playwright improvements #3065

Closed m-bert closed 2 months ago

m-bert commented 3 months ago

Description

I've noticed that our e2e tests don't work anymore. Well.. they (almost) did, I've just wrongly assumed that you can open web on standard metro port 8081 like in our example app. The only thing that required fix was default port number.

Nevertheless, this made me look into our e2e app and it resulted in few changes:

[!WARNING] Previously tests on webkit (i.e. safari) didn't work. Now after upgrading browsers they do... but tests on firefox fail. From what I've found, it is because for some reason Locator.innerText returns empty string. Adding timeout doesn't fix it, so it doesn't seem like race condition. Maybe it will be fixed with new firefox update.

Test plan

Go to e2e/web-tests and run:

  1. yarn start
  2. yarn test
m-bert commented 2 months ago

It would be nice to check the firefox again in the near future

True, maybe it will be fixed in newer versions