software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
6.13k stars 982 forks source link

[2.19.0] The latest version causes a react-native build issue error Failed to build the app: No package name found. Found errors in <project_path>/node_modules/react-native-gesture-handler/android/src/main/AndroidManifest.xml. #3086

Closed thehellmaker closed 2 months ago

thehellmaker commented 2 months ago

Description

[2.19.0] The latest version causes a react-native build issue error Failed to build the app: No package name found. Found errors in /node_modules/react-native-gesture-handler/android/src/main/AndroidManifest.xml.

When the command node /node_modules/@react-native-community/cli/build/bin.js config --debug as a part of gradle build it exits with this error

Steps to reproduce

[2.19.0] The latest version causes a react-native build issue error Failed to build the app: No package name found. Found errors in /node_modules/react-native-gesture-handler/android/src/main/AndroidManifest.xml.

Snack or a link to a repository

none

Gesture Handler version

2.19.0

React Native version

0.70.2

Platforms

MacOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

github-actions[bot] commented 2 months ago

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

migueldaipre commented 2 months ago

Related with https://github.com/software-mansion/react-native-gesture-handler/pull/3077

Bump your react native to v0.73+

latekvo commented 2 months ago

Hi @thehellmaker,

You're currently using React Native version 0.70.2 which we stopped supporting in Gesture Handler 2.18.0 As @migueldaipre mentioned, please make sure to upgrade to React Native version 0.73+