software-mansion / react-native-gesture-handler

Declarative API exposing platform native touch and gesture system to React Native.
https://docs.swmansion.com/react-native-gesture-handler/
MIT License
6.13k stars 982 forks source link

react-native-tvOS not building #3089

Closed SPalkaDolby closed 2 months ago

SPalkaDolby commented 2 months ago

Description

After upgrade from 2.17.1 to 2.19.0 tvOS decided to stop building :) Also tested 2.18.1 and it is working fine. I believe it is connected to: Important changes: [macOS] Add LongPressGestureHandler by @m-bert in https://github.com/software-mansion/react-native-gesture-handler/pull/3014 image

Steps to reproduce

  1. Install

Snack or a link to a repository

Not needed

Gesture Handler version

2.19.0

React Native version

npm:react-native-tvos@0.75.2-0

Platforms

MacOS

JavaScript runtime

Hermes

Workflow

React Native (without Expo)

Architecture

None

Build type

Debug mode

Device

None

Device model

No response

Acknowledgements

Yes

github-actions[bot] commented 2 months ago

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

latekvo commented 2 months ago

Hey @SPalkaDolby, thank you for the report!

Please let me know if this PR fixes your issue

SPalkaDolby commented 2 months ago

@latekvo thanks a lot for your help the fix works and lets build the app ;)

Działa! 🛠️🛠️🛠️