Closed latekvo closed 1 month ago
Also, what's the verdict on https://github.com/software-mansion/react-native-gesture-handler/pull/2962#discussion_r1666562893?
We could use Infinity
to make it cleaner. Your suggested version does not say anything about acceptable values and I think it would be better to keep them. However, I'm still not fond of using [0, -]
, even with Infinity
.
I'm still not fond of using
[0, -]
, even withInfinity
.
Please let me know if the proposal written in description is ok then, it replaces [0, -]
with a regular description of the input-output ranges.
Your suggested version does not say anything about acceptable values and I think it would be better to keep them.
Your suggested version does not say anything about acceptable values and I think it would be better to keep them.
Do either of these work? I think the input-output range is implicitly stated in both of them.
progress
value representing swiping progress relative to the width of the returned element.
Equals 0
when swipeable
is closed, 1
when right action
is open,
and linearly increases to Infinity
as right action
overshoots it's open position.
progress
value representing swiping progress relative to the width of the returned element.
Starts at 0
, increases to 1
as right action
reaches it's open position,
keeps increasing as right action
overshoots it's open position.
What about:
progress
value representing swiping progress relative to the width of the returned element.
Equals 0 when swipeable is closed, 1 when right action is open.
Linearly increases to Infinity
as right action overshoots it's open position.?
Description
Fixed the example provided with the
Reanimated Swipeable
docs, it looks like a fragment of it was missing.Also, what's the verdict on this issue? Today I had to take a look at these docs again and it really occurred to me the way it's currently written can be really confusing.
Here's my proposition, it removes the
[0, +]
mapping in favour of a verbose explanation:Of course this change applies to both
renderLeftActions
andrenderRightActions